-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds basic iteractive menu for inspecting current state of solver when stepping #1039
Conversation
b2d3211
to
e4e706b
Compare
I can't seen to add 2 reviewers to this PR. |
From today's meeting:
Todo:
|
Mentioning @rydrman and @jrray for visibility, because I can't seem to add two reviewers. I've compressed the menu to a single line, adding I made some TODO notes for things that could be done in future, but I'm not planning on doing any of them in this PR. Let me know if you'd rather I make tickets for them. |
e4295f8
to
f88b7f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but have some suggested fixups.
073dacf
to
3645025
Compare
…ed on a block or decision. Adds showing resolved packages, unresolved requests, variable requests, options, and showing all of the those when stepping or stopping during a solve. Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
3645025
to
710d372
Compare
This adds a very basic interactive menu for inspecting current state the solver has reached, when using
--step/stop-on-block
or--step-on-decision
.It adds methods for showing the current state's resolved packages, unresolved requests, variable requests, options, and showing all of the those when stepping or stopping. I imagine more could be added later, e.g. we have a request to launch an environment of the currently resolved packages. I have a plan to add showing graphs of the current dependencies to this menu (PR: TBD).
The menu doesn't use any other crates and appears among the normal solver output, but doesn't use the output setting the solver has. This was partly for initial implementation ease, partly to keep the existing output intact, and partly because its interactive.
Questions:
console_menu
but didn't like it clearing the screen and jumping back and forth between the existing solver output.Gotchas uncovered:
Example output (updated with single line menu):